Add ability to send headers through repositories #103
Conversation
|
By the way, I've noticed that there's an unrelated styling issue in |
|
Thanks for the pr. A thought, shouldn't there be a test with and without a header? |
There was a problem hiding this comment.
By the way, I've noticed that there's an unrelated styling issue in
UtilTest.php(caught bycomposer check-style), but didn't want to make any unrelated changes. Let me know if you'd like me to, or if that should be solved separately.
I'll fix the code style issues separately, thanks!
Thanks for the pr. A thought, shouldn't there be a test with and without a header?
Good point, but since there are currently no tests without the $parameters argument, I think it's fine for this PR.
Description
Accept a new
array $headers = []argument for every method used in repositories (default to an empty array for backward compatibility). Then forward those arguments to the underlying DocumentClient class, which already accepts them.Motivation and context
Closes #102
How has this been tested?
Tested the headers inputs in
RepositoryTestScreenshots (if appropriate)
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!